<html>
<head><meta charset="utf-8"><title>signal stack guard page · t-libs · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/index.html">t-libs</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/signal.20stack.20guard.20page.html">signal stack guard page</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="191006954"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/signal%20stack%20guard%20page/near/191006954" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/signal.20stack.20guard.20page.html#191006954">(Mar 18 2020 at 16:35)</a>:</h4>
<p>Do any libs folks have opinions about adding a guard page to signal stacks? I filed an issue in response to a security report, and someone made a pull request which now looks good to me.<br>
<a href="https://github.com/rust-lang/rust/issues/69533" target="_blank" title="https://github.com/rust-lang/rust/issues/69533">https://github.com/rust-lang/rust/issues/69533</a><br>
<a href="https://github.com/rust-lang/rust/pull/69969" target="_blank" title="https://github.com/rust-lang/rust/pull/69969">https://github.com/rust-lang/rust/pull/69969</a></p>



<a name="191007029"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/signal%20stack%20guard%20page/near/191007029" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/signal.20stack.20guard.20page.html#191007029">(Mar 18 2020 at 16:36)</a>:</h4>
<p>I'd be happy to <code>r+</code> this myself, but I don't want to presume too much</p>



<a name="191012633"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/signal%20stack%20guard%20page/near/191012633" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/signal.20stack.20guard.20page.html#191012633">(Mar 18 2020 at 17:15)</a>:</h4>
<p>LGTM. I can't see any objections on the principle, and the implementation looks fine.</p>



<a name="191012770"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/signal%20stack%20guard%20page/near/191012770" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/signal.20stack.20guard.20page.html#191012770">(Mar 18 2020 at 17:16)</a>:</h4>
<p>The code does make the assumption that the stack grows down, but AFAIK that's true for all architectures that we support.</p>



<a name="191389325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/219381-t-libs/topic/signal%20stack%20guard%20page/near/191389325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/219381-t-libs/topic/signal.20stack.20guard.20page.html#191389325">(Mar 22 2020 at 10:03)</a>:</h4>
<p>Seems reasonable to me.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>